[jira] [Commented] (XERCESC-2100) [patch] Small fixes for warnings and errors

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (XERCESC-2100) [patch] Small fixes for warnings and errors

JIRA xerces-c-dev@xml.apache.org

    [ https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047956#comment-16047956 ]

Scott Cantor commented on XERCESC-2100:
---------------------------------------

There's also no reason not to make the change for simple correctness, though I would look at the code and determine if the inline approach is what we want. ABI stability is much harder the more we inline so it might be better to start reducing that. Performance and Xerces really aren't in the same zip code, so I don't think gaining a few CPU cycles is a factor. If we're going to change the ABI, which we are, we might want to consistently de-inline a lot of the code.

> [patch] Small fixes for warnings and errors
> -------------------------------------------
>
>                 Key: XERCESC-2100
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2100
>             Project: Xerces-C++
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Roger Leigh
>              Labels: patch
>         Attachments: 0001-build-Merge-MsgCatalog-Makefile.in-with-src-Makefile.patch, 0002-cmake-Debug-FindThreads.patch, 0003-cmake-Minimum-C-standard-is-C-98-but-also-try-later-.patch, 0004-cmake-XercesIntTypes-Add-a-cstdint-functional-check.patch, 0005-cmake-Enable-extra-compiler-warnings.patch, 0006-samples-PSVIWriterHandlers.cpp-Use-delete-in-place-o.patch, 0007-tests-EncodingTest.cpp-Use-correct-format-strings-to.patch, 0008-tests-DTest.cpp-Use-correct-format-strings-to-match-.patch, 0009-tests-ThreadTest.cpp-Handle-all-node-types-in-switch.patch, 0010-tests-XSValueTest-Don-t-warn-about-integer-limit-pro.patch, 0011-xercesc-Don-t-warn-about-private-constructors-with-G.patch, 0012-xercesc-DOMParentNode-Add-missing-virtual-destructor.patch, 0013-xercesc-NamespaceScope-Add-missing-virtual-destructo.patch, 0014-xercesc-NamespaceScope-Correct-initialisation-order.patch, 0015-samples-PSVIWriterHandlers-Remove-unused-variables.patch, 0016-xercesc-DOMLSSerializerImpl-Remove-unused-variable.patch, 0017-xercesc-XMLUri-Remove-unused-variables.patch, 0018-xercesc-RangeToken-Conditionally-define-variable-if-.patch, 0019-xercesc-DatatypeValidatorFactory-Remove-unused-varia.patch, 0020-tests-DTest-Remove-unused-variables.patch, 0021-tests-MemoryMonitor-Remove-unused-variable.patch, 0022-tests-XSTSHarness-Remove-unused-variables.patch, 0023-tests-XSValueTest-Conditionally-define-conditionally.patch, 0024-xercesc-PlatformUtils-Include-sys-timeb.h-conditiona.patch, 0025-xercesc-BinMemInputStream-Add-missing-const_cast.patch, 0026-xercesc-QName-Add-mising-const_casts.patch, 0027-xercesc-XMLUri-Add-missing-const_cast.patch, 0028-xercesc-DOMLSSerializerImpl-Suppress-cast-alignment-.patch, 0029-xercesc-EncodingValidator-Suppress-cast-alignment-wa.patch, 0030-xercesc-XProtoType-Suppress-cast-alignment-warning.patch, 0031-xercesc-DOMCasts-Suppress-cast-alignment-warnings.patch, 0032-xercesc-XMLReader-Suppress-cast-alignment-warnings.patch, 0033-xercesc-XSerializeEngine-Suppress-cast-alignment-war.patch, 0034-xercesc-XML-Transcoder-Suppress-cast-alignment-warni.patch, 0035-xercesc-CMStateSet-Suppress-cast-alignment-warnings.patch
>
>
> These patches have been sitting around for nearly a year, but I've rebased them onto the trunk and tested them again.  They cover several classes of fix:
> - minor build improvements
> - minor tweaks to feature tests
> - enabling stricter compiler warnings, and then fixing those warnings
> - fixing mismatched delete/delete[] (bad)
> - adding missing virtual destructors (bad)
> - removing unused variables
> - removing unused variables conditionally when used conditionally
> - removing cast warnings with appropriate C++ const/static/reinterpret casts
> Most of the fixes are tiny one-liners to fix warnings.
> Builds:
> - [travis|https://travis-ci.org/rleigh-codelibre/xerces-c/builds/241812965]
> - [appveyor|https://ci.appveyor.com/project/rleigh-codelibre/xerces-c/build/1.0.90]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]